[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 3 06:01:08 PDT 2019
labath added inline comments.
Comment at: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py:160
The second failure I had was due to the full module showing up when the module was found, so this check failed.
The interesting part (and the reason why I checked out this patch) was that the module was still being found even when I removed the `basename_module_spec.GetFileSpec().GetDirectory().Clear();` line, which was my last uncertainty about this patch. So now I even more strongly believe that the clearing of the directory file spec is unnecessary and should be removed.
Comment at: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py:176
+ so_path = self.getBuildArtifact("libuuidmismatch.so")
+ self.yaml2obj("libuuidmatch.yaml", so_path)
I think this is one of the causes of failure. Changing this to libuuidmismatch.yaml made it work for me.
CHANGES SINCE LAST ACTION
More information about the lldb-commits