[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

Wed Apr 3 00:25:47 PDT 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I think we can give this a shot. We can always re-disable tests that are still flaky and iterate. Thank you for working on this.

================
Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:95-97
+        # Wait for a bit to ensure the process is launched, but not for so long
+        # that the process has already finished by the time we attach.
+        time.sleep(3)
----------------
I am not sure this will be enough. I've seen tests fail sporadically (like 1 time out of a 1000 or so) even with bigger margins than this. I'd increase the wait in the test to at least 10 seconds. If you don't want to wait that long in the common case when things finish quickly, you can implement a `debugger_flag` pattern like some of the other tests do: <https://github.com/llvm-mirror/lldb/blob/master/packages/Python/lldbsuite/test/functionalities/attach_resume/main.cpp>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60153/new/

https://reviews.llvm.org/D60153