[Lldb-commits] [lldb] r357456 - Fix llvm_unreachable in TestWriteMemory

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 2 01:56:22 PDT 2019


Author: labath
Date: Tue Apr  2 01:56:22 2019
New Revision: 357456

URL: http://llvm.org/viewvc/llvm-project?rev=357456&view=rev
Log:
Fix llvm_unreachable in TestWriteMemory

The test was hitting llvm_unreachable in
Platform::GetSoftwareBreakpointTrapOpcode because it could not figure
out the architecture of the process. Since that is not the purpose of
the test, I change the test to use an explicit
CreateTargetWithFileAndTargetTriple command to specify it.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py?rev=357456&r1=357455&r2=357456&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py Tue Apr  2 01:56:22 2019
@@ -14,7 +14,7 @@ class TestWriteMemory(GDBRemoteTestBase)
                 return "OK"
 
         self.server.responder = MyResponder()
-        target = self.dbg.CreateTarget('')
+        target = self.dbg.CreateTargetWithFileAndTargetTriple('', 'x86_64-pc-linux')
         process = self.connect(target)
 
         bp = target.BreakpointCreateByAddress(0x1000)




More information about the lldb-commits mailing list