[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 1 14:51:02 PDT 2019


amccarth accepted this revision.
amccarth added inline comments.


================
Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:287
+
+  // lookup register reference as lvalue in preceding assignments
+  auto it = m_dependent_programs.find(symbol->GetName());
----------------
nit:  As long as you're correcting this comment, can you fix "look up" to be two words?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60068/new/

https://reviews.llvm.org/D60068





More information about the lldb-commits mailing list