[Lldb-commits] [PATCH] D53412: [lldb] Fixed deadlock when SBProcess is Kill()ed and inspected
Cameron via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 1 12:11:08 PDT 2019
cameron314 added a comment.
In D53412#1450182 <https://reviews.llvm.org/D53412#1450182>, @clayborg wrote:
> All of these are in SBProcess. No need to change everywhere else, I just see a ton of duplicated code here in the SBProcess.cpp. If we contain those in a small struct/class, then we can easily make changes as needed without 50 diffs in this file each time. So no need to fix all the call sites in this patch, just the ones in SBProcess.cpp
Ah, that makes more sense :-) Sorry I misinterpreted your suggestion.
I can add a RAII lock-helper struct in SBProcess, but the order that locks are taken within it must not be modified without changing *all* the functions that take both locks (both directly and indirectly), which includes a significant portion of the SB API (and not just SBProcess).
CHANGES SINCE LAST ACTION
More information about the lldb-commits