[Lldb-commits] [PATCH] D59976: [Python] Remove Python include from ScriptInterpreterPython.h

Fri Mar 29 13:09:31 PDT 2019

JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.

Thanks for the review, Pavel!

================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1229-1230
+  Locker locker(this,
+                ScriptInterpreterPythonImpl::Locker::AcquireLock |
+                    ScriptInterpreterPythonImpl::Locker::InitSession |
+                    (options.GetSetLLDBGlobals()
----------------
labath wrote:
> The `ScriptInterpreterPythonImpl` qualification on the `Locker` class is probably overkill. (I know it was present before this patch, but it's overkill there too :P ).
Makes sense, I'll remove it before landing.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59976/new/

https://reviews.llvm.org/D59976