[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 28 14:52:13 PDT 2019


aprantl added a comment.

Thanks for summarizing your thoughts, Davide.

I think that what you wrote is a much better explanation of what I was trying to say with

  Use these sparingly and only if error handling is not otherwise feasible.

I think that unless we can eliminate all uses of lldb_assert() from the code we should document it, but discourage its use. Do you have any suggestions for a better wording?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59911/new/

https://reviews.llvm.org/D59911





More information about the lldb-commits mailing list