[Lldb-commits] [PATCH] D59896: [ObjectFileMachO] Disable memory caching for savecore.

Wed Mar 27 16:42:08 PDT 2019

davide added a comment.

In D59896#1445310 <https://reviews.llvm.org/D59896#1445310>, @jasonmolenda wrote:

> Looks good.  Removing that printf is good.  Could you also remove the printf("mach_header:...") in the same function?
>
> It would be nice if include/lldb/Target/Process.h had the decl for ReadMemoryFromInferior right after ReadMemory(), and a comment that ReadMemoryFromInferior does not go through the memory cache (and most callers should go through ReadMemory()) so people know what the difference is.

I'll do that as a follow-up. Thank you Jason!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59896/new/

https://reviews.llvm.org/D59896