[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

[Pavel Labath via Phabricator via lldb-commits]

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

In D59854#1444108 <https://reviews.llvm.org/D59854#1444108>, @mgorny wrote:

> Is there a reason you can't reuse/extend `DynamicLibrary` from `LLVMSupport`?


+1. It sounds like you don't need anything fancy here, and this functionality should already be available in llvm.

Also, this is not relevant here, but as I think I know where this is heading, I feel like I should point out that the API surface shared with the loaded library will need to be annotated with __declspec(dllimport/export) in order for things to work on windows. If you're going to be dlopening libpython (that's how I'd probably do it, but it wouldn't give us real "plugins"), then this should already be taken care of. However, if you want to dlopen some lldb custom library, then any stuff that crosses the dll boundary will probably need to be anotated (this may include llvm classes like StringRef etc.)...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59854/new/

https://reviews.llvm.org/D59854