[Lldb-commits] [PATCH] D59828: Add lldb-vscode as a dependency of lldb tests.

Jorge Gorbe Moya via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 26 11:03:16 PDT 2019


jgorbe created this revision.
jgorbe added a reviewer: clayborg.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.

In the current state, 'ninja check-lldb' runs the lldb-vscode tests, but it
won't rebuild lldb-vscode if any of its sources has changed. This is very
confusing when you fix something and the tests keep failing, or vice versa.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D59828

Files:
  lldb/CMakeLists.txt


Index: lldb/CMakeLists.txt
===================================================================
--- lldb/CMakeLists.txt
+++ lldb/CMakeLists.txt
@@ -91,6 +91,10 @@
     list(APPEND LLDB_TEST_DEPS lldb-mi)
   endif()
 
+  if(TARGET lldb-vscode)
+    list(APPEND LLDB_TEST_DEPS lldb-vscode)
+  endif()
+
   if(TARGET lldb-instr)
     list(APPEND LLDB_TEST_DEPS lldb-instr)
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59828.192296.patch
Type: text/x-patch
Size: 380 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190326/773c4cae/attachment.bin>


More information about the lldb-commits mailing list