[Lldb-commits] [PATCH] D59667: Regression test to ensure that we handling importing of anonymous enums correctly

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 22 08:37:01 PDT 2019


aprantl added inline comments.


================
Comment at: packages/Python/lldbsuite/test/expression_command/cast_int_to_anonymous_enum/main.cpp:1
+#include <cstdio>
+
----------------
You can speed up compilation time of this test significantly by removing the printf and the include of cstdio.




================
Comment at: packages/Python/lldbsuite/test/expression_command/cast_int_to_anonymous_enum/main.cpp:8
+int main() {
+   flow_e f;
+
----------------
It looks like this variable is not actually used by the test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59667/new/

https://reviews.llvm.org/D59667





More information about the lldb-commits mailing list