[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 21 03:45:42 PDT 2019


labath updated this revision to Diff 191653.
labath added a comment.

It occurred to me that the "invalid input" test cases could be easily rewritten
in lit, as they don't require parsing of the generated binary (because there
isn't one).

In this update I just port those tests to lit, which enables us to actually
assert the error message (which isn't possible from the unit test as that
unfortunately goes to stderr).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59482/new/

https://reviews.llvm.org/D59482

Files:
  include/llvm/ObjectYAML/MinidumpYAML.h
  include/llvm/ObjectYAML/ObjectYAML.h
  lib/ObjectYAML/CMakeLists.txt
  lib/ObjectYAML/MinidumpYAML.cpp
  lib/ObjectYAML/ObjectYAML.cpp
  test/tools/yaml2obj/minidump-raw-stream-small-size.yaml
  test/tools/yaml2obj/minidump-systeminfo-other-long.yaml
  test/tools/yaml2obj/minidump-systeminfo-other-not-hex.yaml
  test/tools/yaml2obj/minidump-systeminfo-other-short.yaml
  test/tools/yaml2obj/minidump-systeminfo-x86-long.yaml
  test/tools/yaml2obj/minidump-systeminfo-x86-short.yaml
  tools/yaml2obj/CMakeLists.txt
  tools/yaml2obj/yaml2minidump.cpp
  tools/yaml2obj/yaml2obj.cpp
  tools/yaml2obj/yaml2obj.h
  unittests/ObjectYAML/CMakeLists.txt
  unittests/ObjectYAML/MinidumpYAMLTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59482.191653.patch
Type: text/x-patch
Size: 32467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190321/cd23773f/attachment-0001.bin>


More information about the lldb-commits mailing list