[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 20 13:36:45 PDT 2019


clayborg added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:552
+  data.Clear();
+  m_obj_file->ReadSectionData(section_sp.get(), data);
 }
----------------
clayborg wrote:
> ```
> if (m_obj_file->ReadSectionData(section_sp.get(), data) == 0)
>   data.Clear();
> ```
What do you think about this one? This is my last nit


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59562/new/

https://reviews.llvm.org/D59562





More information about the lldb-commits mailing list