[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 20 08:32:32 PDT 2019


clayborg added a comment.

We can get rid of the m_dwarf_data all together. As Pavel suggested, we used to not mmap the entire file, and now we do most of the time. The Section::GetSectionData() will ref count the mmap data in the data extractor and use the mmap already, so we should only support grabbing the contents via the Section::GetSectionData() and don't propagate this legacy code in the new DWARFContext.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59562/new/

https://reviews.llvm.org/D59562





More information about the lldb-commits mailing list