[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

[Greg Clayton via Phabricator via lldb-commits]

clayborg marked an inline comment as done.
clayborg added inline comments.


================
Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py:533
+        self.assertEqual(2, len(modules))
+        self.verify_module(modules[0], "/tmp/a", None)
+        self.verify_module(modules[1], "/tmp/b", None)
----------------
serge-sans-paille wrote:
> labath wrote:
> > Am I right in thinking that if I have an object file called `/tmp/a` on my system, then lldb will pick it up (and it's build-id), causing this test to fail ? If that's the case then it would be better to use some path which is less likely to exist.
> I second this. https://docs.python.org/3/library/tempfile.html provides ways to create such temporary names.
These have strict UUID values that must match and the value is hard coded into the minidump files. So even if there is such a file, the UUID won't match.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59433/new/

https://reviews.llvm.org/D59433