[Lldb-commits] [PATCH] D59587: Use explicit loop instead of map for Python 2/3 compat

serge via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 20 00:28:55 PDT 2019

serge-sans-paille created this revision.
serge-sans-paille added a reviewer: michaelplatings.
Herald added subscribers: lldb-commits, jdoerfert.
Herald added a project: LLDB.

The output of map is not used, so using a list comprehension or an explicit call to list looks awkward.




Index: lldb/scripts/Xcode/build-llvm.py
--- lldb/scripts/Xcode/build-llvm.py
+++ lldb/scripts/Xcode/build-llvm.py
@@ -239,7 +239,8 @@
 def all_check_out_if_needed():
-    map(check_out_if_needed, XCODE_REPOSITORIES())
+    for r in XCODE_REPOSITORIES():
+        check_out_if_needed(r)
 def should_build_llvm():
@@ -263,7 +264,8 @@
 def setup_source_symlinks():
-    map(setup_source_symlink, XCODE_REPOSITORIES())
+    for r in XCODE_REPOSITORIES():
+        setup_source_symlink(r)
 def setup_build_symlink():

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59587.191449.patch
Type: text/x-patch
Size: 596 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190320/8da79116/attachment.bin>

More information about the lldb-commits mailing list