[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 19 15:12:44 PDT 2019
JDevlieghere added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.h:30
+
+ const DWARFDataExtractor *maybeLoadArangesData();
+
----------------
Why do we need these two methods? I presume it's because one does work and the other doesn't? If I understand the code correctly, `LoadOrGetSection` will initialize the optional, so could you just check the optional to determine where we should try to do work or not?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59562/new/
https://reviews.llvm.org/D59562
More information about the lldb-commits
mailing list