[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 18 10:05:14 PDT 2019

zturner created this revision.
zturner added reviewers: JDevlieghere, aprantl.
Herald added a subscriber: jdoerfert.

I don't find these specific log statements particularly high value, as they appear more just like simple function tracing calls (i.e. they log low level implementation details, not high level program flow) so I'm removing them from the low level DWARF parsing libraries.

I'm prepared to be convinced that we actually should do something other than outright delete them, but I did look at each one specifically as well as the surrounding context before deciding that they were probably ok to delete.

My reasoning for deleting these is that they are all on the success codepath and have a very limited number of call-sites (in most cases actually just 1), so in most cases a previous log statement would necessarily be followed by the deleted log statement, so therefore it doesn't actually add much (if any) diagnostic value.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59498.191118.patch
Type: text/x-patch
Size: 4965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190318/3ab993d6/attachment.bin>

More information about the lldb-commits mailing list