[Lldb-commits] [PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter
Balázs Kéri via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Mar 18 06:34:46 PDT 2019
balazske added a comment.
The replace of `Import` calls may work if the internal state of the `ASTImporter` is updated correctly from the 'shim' object (especially if not every Decl is handled by the shim). For this to work some of the state of `ASTImporter` that was intended to be internal must be made public, for example map of imported decls and lookup table. The shim may corrupt the `ASTImporter` state for example when the lookup table is not updated correctly. (Probably for the LLDB special use cases this is not a problem?)
CHANGES SINCE LAST ACTION
More information about the lldb-commits