[Lldb-commits] [PATCH] D59297: Delete type_sp member from TypePair

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 13 07:02:26 PDT 2019


labath created this revision.
labath added reviewers: clayborg, zturner, jingham.
Herald added a subscriber: jdoerfert.

As discussed in the review of D59217 <https://reviews.llvm.org/D59217>, this member is unnecessary since
always the first thing we do is convert it to a CompilerType.

This opens up possibilities for further cleanups (e.g. the whole
TypePair class now loses purpose, since we can just pass around
CompilerType everywhere), but I did not want to do that yet, because I
am not sure if this will not introduce breakages in some of the
platforms/configurations that I am not testing on.


https://reviews.llvm.org/D59297

Files:
  include/lldb/DataFormatters/FormatClasses.h
  include/lldb/Symbol/Type.h
  source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
  source/Symbol/Type.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59297.190410.patch
Type: text/x-patch
Size: 7051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190313/07107e27/attachment.bin>


More information about the lldb-commits mailing list