[Lldb-commits] [PATCH] D59291: Add basic minidump support to obj2yaml

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 13 03:45:35 PDT 2019


labath created this revision.
labath added reviewers: Bigcheese, jhenderson, zturner.
Herald added subscribers: fedor.sergeev, mgorny, dschuff, srhines.
Herald added a project: LLVM.

This commit adds enough code to be able to dump a simple minidump (a
windows "core" file) file into yaml. It consists of the following parts:

- the declarations of various structures and constants in the BinaryFormat library
- a basic minidump parser in the Object library
- code for converting a parsed minidump file into YAML

The three parts could technically be submitted separately, but I put them in a
single patch here since there is no way to test the first two parts until we are
able to produce some output.

After this patch, the development can go in three directions which can
be worked on more-or-less in parallel (and in smaller chunks):

- Add support for more stream types
- yaml2obj support for minidump files
- rebase lldb's minidump handling code onto the llvm Object parser


Repository:
  rL LLVM

https://reviews.llvm.org/D59291

Files:
  include/llvm/BinaryFormat/Magic.h
  include/llvm/BinaryFormat/Minidump.h
  include/llvm/BinaryFormat/MinidumpConstants.def
  include/llvm/Object/Binary.h
  include/llvm/Object/Minidump.h
  include/llvm/ObjectYAML/MinidumpYAML.h
  lib/BinaryFormat/Magic.cpp
  lib/Object/Binary.cpp
  lib/Object/CMakeLists.txt
  lib/Object/Minidump.cpp
  lib/Object/ObjectFile.cpp
  lib/Object/SymbolicFile.cpp
  lib/ObjectYAML/CMakeLists.txt
  lib/ObjectYAML/MinidumpYAML.cpp
  test/tools/obj2yaml/Inputs/basic-minidump.dmp
  test/tools/obj2yaml/basic-minidump.test
  tools/obj2yaml/CMakeLists.txt
  tools/obj2yaml/minidump2yaml.cpp
  tools/obj2yaml/obj2yaml.cpp
  tools/obj2yaml/obj2yaml.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59291.190392.patch
Type: text/x-patch
Size: 42497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190313/04476b4b/attachment-0001.bin>


More information about the lldb-commits mailing list