[Lldb-commits] [lldb] r356002 - [testsuite] Remove other traces broken in python 3.

Davide Italiano via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 12 19:44:32 PDT 2019


Author: davide
Date: Tue Mar 12 19:44:32 2019
New Revision: 356002

URL: http://llvm.org/viewvc/llvm-project?rev=356002&view=rev
Log:
[testsuite] Remove other traces broken in python 3.

They can be reinstated in case somebody needs to debug
this test in the future.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py?rev=356002&r1=356001&r2=356002&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/python_api/sbdata/TestSBData.py Tue Mar 12 19:44:32 2019
@@ -66,13 +66,8 @@ class SBDataAPICase(TestBase):
         self.assertIsNotNone(thread)
 
         frame = thread.GetSelectedFrame()
-        if self.TraceOn():
-            print(frame)
         foobar = frame.FindVariable('foobar')
         self.assertTrue(foobar.IsValid())
-        if self.TraceOn():
-            print(foobar)
-
         data = foobar.GetPointeeData(0, 2)
         offset = 0
         error = lldb.SBError()
@@ -130,9 +125,6 @@ class SBDataAPICase(TestBase):
 
         data = star_foobar.GetData()
 
-        if self.TraceOn():
-            print(data)
-
         offset = 0
         self.assert_data(data.GetUnsignedInt32, offset, 1)
         offset += 4
@@ -151,14 +143,8 @@ class SBDataAPICase(TestBase):
         new_foobar = foobar.CreateValueFromAddress(
             "f00", foobar_addr, star_foobar.GetType())
         self.assertTrue(new_foobar.IsValid())
-        if self.TraceOn():
-            print(new_foobar)
-
         data = new_foobar.GetData()
 
-        if self.TraceOn():
-            print(data)
-
         self.assertTrue(data.uint32[0] == 8, 'then foo[1].a == 8')
         self.assertTrue(data.uint32[1] == 7, 'then foo[1].b == 7')
         # exploiting that sizeof(uint32) == sizeof(float)
@@ -182,9 +168,6 @@ class SBDataAPICase(TestBase):
 
         data = new_foobar.GetData()
 
-        if self.TraceOn():
-            print(data)
-
         offset = 0
         self.assert_data(data.GetUnsignedInt32, offset, 8)
         offset += 4
@@ -204,13 +187,6 @@ class SBDataAPICase(TestBase):
         barfoo = frame.FindVariable('barfoo')
 
         data = barfoo.GetData()
-
-        if self.TraceOn():
-            print(barfoo)
-
-        if self.TraceOn():
-            print(data)
-
         offset = 0
         self.assert_data(data.GetUnsignedInt32, offset, 1)
         offset += 4
@@ -241,10 +217,6 @@ class SBDataAPICase(TestBase):
         new_object = barfoo.CreateValueFromData(
             "new_object", data, barfoo.GetType().GetBasicType(
                 lldb.eBasicTypeInt))
-
-        if self.TraceOn():
-            print(new_object)
-
         self.assertTrue(new_object.GetValue() == "1", 'new_object == 1')
 
         if data.GetByteOrder() == lldb.eByteOrderBig:
@@ -271,9 +243,6 @@ class SBDataAPICase(TestBase):
 
         data.Append(data2)
 
-        if self.TraceOn():
-            print(data)
-
         # this breaks on EBCDIC
         offset = 0
         self.assert_data(data.GetUnsignedInt32, offset, 65)




More information about the lldb-commits mailing list