[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:89
   }
   llvm_unreachable("invalid UnitType.");
 }
----------------
Not your code, but this application of `llvm_unreachable` seems suspicious unless we can guarantee that we already checked for a supported format before entering here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59235/new/

https://reviews.llvm.org/D59235