[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:263
   uint64_t length = data.GetU32(&offset);
-  bool isDwarf64 = (length == 0xffffffff);
-  if (isDwarf64)
----------------
Here should be an error that DWARF64 is not supported.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:170
     case DW_FORM_sec_offset:
       assert(m_cu);
+      m_value.value.uval = data.GetMaxU64(offset_ptr, 4);
----------------
Delete the assert?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:327
     case DW_FORM_strp:
       assert(cu);
+      *offset_ptr += 4;
----------------
Delete the assert?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59235/new/

https://reviews.llvm.org/D59235