[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

Mon Mar 11 16:16:05 PDT 2019

zturner added a subscriber: jankratochvil.
zturner added a comment.

In D59235#1425417 <https://reviews.llvm.org/D59235#1425417>, @clayborg wrote:

> What part of parsing DWARF64 wasn't working? I think the SPARC compiler was the only one producing DWARF64.

This patch originated from a thread on lldb-dev where I asked if anyone knows the status.  The first response was from @jankratochvil at Red Hat who gave this example:

  IMO there isn't as for example:
  lldb/source/Plugins/SymbolFile/DWARF/DIERef.cpp
  is using bits 32..63 for additional info (DWO file offset/index for example)
  while only bits 0..31 are used for DIE offset inside .debug_info section.

However, presumably this was identified from Jan simply looking at the code.  There could be other such examples.

> Be a shame to lose the support.   What is the plan here after this patch?

Currently I'm doing some very preliminary investigation into merging LLVM and LLDB's DWARF parsers.  Initially, I started by updating LLVM's `DataExtractor` class to accept `size_t` offsets instead of `uint32_t`, however that quickly grew into a very large patch.

To answer your question: I think the plan would be to first standardize on a single DWARF parser, and then if / when we decide to support DWARF64, do it in one place (and importantly, make sure it has some corresponding test coverage).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59235/new/

https://reviews.llvm.org/D59235