[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/TestImportStdModule.py:19
+    @skipIf(oslist=no_match(["linux"]))
+    @skipIf(debug_info=no_match(["dwarf"]))
+    def test(self):
----------------
teemperor wrote:
> aprantl wrote:
> > Do you understand why the "dwarf" is necessary?
> The test relies on having the module imports with their include directories listed in the debug info, which I think only dwarf supports for now? It fails for dwo at the moment and I guess there is no equivalent in PDB (can't test this though).
The debug info *format* should not have any semantic effect on the contents, so you probably found some kind of bug. At least dwarf and dwo should behave the same on Linux, as should dsym and dwarf on Darwin. PDB actually can have different contents because it's completely different; skippin gthat makes sense to me. Feel free to investigate this separately though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58125/new/

https://reviews.llvm.org/D58125