[Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

[Dave Lee via lldb-commits]

Yeah given the evidence, maybe it's fine left as is. I worked around it
locally so I am not blocked. Thanks!

On Monday, March 11, 2019, Jonas Devlieghere <jonas at devlieghere.com> wrote:

> It's weird that this only occurs when building with Xcode, none of the
> bots seem affected. Anyway, I'm updating the macros and verifying the build
> works locally when using Xcode.
>
> On Sun, Mar 10, 2019 at 3:25 PM Dave Lee via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> kastiglione added a comment.
>>
>> I'm getting build failures that appear to be caused by this patch. I'm
>> compiling on macOS with Xcode 10.1. The failures are uses of
>> `LLDB_RECORD_DUMMY()`, passing a callback function pointer as one of the
>> args. This results in errors like:
>>
>>   ../../tools/lldb/include/lldb/Utility/ReproducerInstrumentation.h:37:6:
>> error: invalid operands to binary expression ('llvm::raw_string_ostream'
>> and 'bool (*)(void *, lldb::SBProcess &, lldb::SBThread &,
>> lldb::SBBreakpointLocation &)')
>>     ss << t;
>>     ~~ ^  ~
>>
>> and
>>
>>   ../../include/llvm/Support/raw_ostream.h:202:16: note: candidate
>> function not viable: no known conversion from 'bool (*)(void *,
>> lldb::SBProcess &, lldb::SBThread &, lldb::SBBreakpointLocation &)' to
>> 'const void *' for 1st argument; take the address of the argument with &
>>     raw_ostream &operator<<(const void *P);
>>
>>
>> Repository:
>>   rLLDB LLDB
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D59101/new/
>>
>> https://reviews.llvm.org/D59101
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190311/a0b4cba6/attachment.html>