[Lldb-commits] [PATCH] D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath()

[Zachary Turner via Phabricator via lldb-commits]

zturner added inline comments.


================
Comment at: source/Target/StackFrame.cpp:644-645
         if (error.Fail()) {
           error.SetErrorStringWithFormatv(
               "Failed to dereference sythetic value: %s", deref_error);
           return ValueObjectSP();
----------------
Not your code, but incidentally this looks wrong.  formatv uses python style format strings where you don't specify the type code but instead specify something like `{0}`.  So either the function is incorrectly named or the call is incorrect.


================
Comment at: source/Target/StackFrame.cpp:650-651
+        if (!valobj_sp) {
+          error.SetErrorStringWithFormatv(
+              "Failed to dereference sythetic value");
+          return ValueObjectSP();
----------------
I think you can' just write this as `SetErrorString`, since there is no format happening.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59200/new/

https://reviews.llvm.org/D59200