[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

Interesting, I had looked at fixing this one once before but I didn't realize we had a class named `EvaluateExpressionOptions` that contained just the right set of information, and it felt gross to invent a new one just for this purpose (It's a good thing I didn't too, since we already had another one).

Can you also update the CMake files?  You'll need to update `Expression/CMakeLists.txt` to not pull in `lldbTarget`.  I was going to say that you would also need to update `unittests/Expression/CMakeLists.txt`, but it's already not listed, so I guess it's just been relying on linking it transitively.

Do you have the ability to test the build with CMake?  If so, could you try `ninja ExpressionTests` and make sure everything still works after removing the link dependcy in `Expression/CMakeLists.txt`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59158/new/

https://reviews.llvm.org/D59158