[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 8 15:32:24 PST 2019


JDevlieghere added inline comments.


================
Comment at: lldb/source/Expression/REPL.cpp:10
 #include "lldb/Expression/REPL.h"
+#include "lldb/Commands/CommandObjectExpression.h"
 #include "lldb/Core/Debugger.h"
----------------
zturner wrote:
> AFAICT, this doesn't really appear to break the dependency does it?  Because right here, Expression will still cause a link dependency against Commands.  
Yeah you're totally right, I'm doing too many things at the same time. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59158/new/

https://reviews.llvm.org/D59158





More information about the lldb-commits mailing list