[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

I think maybe part of the problem is that this patch looks like actually 2 things.  1) A move of the include files from `lldb/source/Commands` to `lldb/Include/lldb/Commands`, and 2) The dependency changes.  So it makes it hard to see what changes are actually needed for breaking the dependency.

Would it be possible to first move the header files as an independent change (which probably doesn't even need to be clang-formatted), and then after that fix the dependency issues?



================
Comment at: lldb/source/Expression/REPL.cpp:10
 #include "lldb/Expression/REPL.h"
+#include "lldb/Commands/CommandObjectExpression.h"
 #include "lldb/Core/Debugger.h"
----------------
AFAICT, this doesn't really appear to break the dependency does it?  Because right here, Expression will still cause a link dependency against Commands.  


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59158/new/

https://reviews.llvm.org/D59158