[Lldb-commits] [PATCH] D59072: [ExpressionParser] Implement ComputeClangResourceDir for Windows

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 7 14:39:46 PST 2019


xiaobai added a comment.

In D59072#1422059 <https://reviews.llvm.org/D59072#1422059>, @stella.stamenova wrote:

> This broke the Windows bot because now one of the TestPaths tests passes on Windows:
>
> http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2394
>
> There's also this comment in the test file:
>
> 1. TODO: Merge into test_path when GetClangResourceDir is implemented on
> 2. windows


Submitted a forward fix with rL355648 <https://reviews.llvm.org/rL355648>


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59072/new/

https://reviews.llvm.org/D59072





More information about the lldb-commits mailing list