[Lldb-commits] [lldb] r355610 - [Reproducers] Disable registering lldb::thread_t everywhere

[Jonas Devlieghere via lldb-commits]

Author: jdevlieghere
Date: Thu Mar  7 09:27:33 2019
New Revision: 355610

URL: http://llvm.org/viewvc/llvm-project?rev=355610&view=rev
Log:
[Reproducers] Disable registering lldb::thread_t everywhere

As discussed on the mailing list, default serialization for thread ids
is not correct, even if they're represented as basic types. I'm
purposely leaving the corresponding record macros in place so that we
don't break the API boundary detection.

Modified:
    lldb/trunk/source/API/SBReproducer.cpp

Modified: lldb/trunk/source/API/SBReproducer.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBReproducer.cpp?rev=355610&r1=355609&r2=355610&view=diff
==============================================================================
--- lldb/trunk/source/API/SBReproducer.cpp (original)
+++ lldb/trunk/source/API/SBReproducer.cpp Thu Mar  7 09:27:33 2019
@@ -1116,17 +1116,6 @@ SBRegistry::SBRegistry() {
     LLDB_REGISTER_STATIC_METHOD(lldb::SBFileSpec, SBHostOS,
                                 GetUserHomeDirectory, ());
     LLDB_REGISTER_STATIC_METHOD(void, SBHostOS, ThreadCreated, (const char *));
-#ifndef _WIN32
-    // FIXME: On Windows, lldb::thread_t is just a void*, so the we will try to
-    //        allocate an object of type void when deserializing.
-    LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadCancel,
-                                (lldb::thread_t, lldb::SBError *));
-    LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadDetach,
-                                (lldb::thread_t, lldb::SBError *));
-    LLDB_REGISTER_STATIC_METHOD(
-        bool, SBHostOS, ThreadJoin,
-        (lldb::thread_t, lldb::thread_result_t *, lldb::SBError *));
-#endif
   }
   {
     LLDB_REGISTER_CONSTRUCTOR(SBInstruction, ());