[Lldb-commits] [PATCH] D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp

[Jim Ingham via Phabricator via lldb-commits]

jingham marked 3 inline comments as done.
jingham added a comment.

I want to keep this commit simple so I'm leaving Adrian's substantial comments for a future commit.



================
Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:136
+      else
+        return;
+      break;
----------------
aprantl wrote:
> This `else return` doesn't do anything. Is it needed for swift-lldb? Otherwise I'd just delete it.
This is not required for swift, this is all C code and is just a straight copy of what used to be in ExpressionSourceCode.cpp.  It's just the way Sean wrote it.  I would rather not add extra differences before merging this back to swift, but I've made a note to fix it once I get that done.


================
Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:1
+//===-- ClangExpressionSourceCode.h ----------------------------------*- C++ -*-===//
+//
----------------
aprantl wrote:
> Level 10 nitpick: can you delete a few `-` characters so this fits into 80 columns?
I'll do that on checkin.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59040/new/

https://reviews.llvm.org/D59040