[Lldb-commits] [PATCH] D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:136
+      else
+        return;
+      break;
----------------
This `else return` doesn't do anything. Is it needed for swift-lldb? Otherwise I'd just delete it.


================
Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:1
+//===-- ClangExpressionSourceCode.h ----------------------------------*- C++ -*-===//
+//
----------------
Level 10 nitpick: can you delete a few `-` characters so this fits into 80 columns?


================
Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h:42
+  // passed to CreateWrapped. Return true if the bounds could be found.  This
+  // will also work on text with FixItHints applied.
+  static bool GetOriginalBodyBounds(std::string transformed_text,
----------------
`///`


================
Comment at: source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp:45
+  m_function_text.assign(ClangExpressionSourceCode::g_expression_prefix);
+  if (text && text[0])
+    m_function_text.append(text);
----------------
Optional: If we changed the interface to llvm::StringRef() we don't have to check for a nullptr.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59040/new/

https://reviews.llvm.org/D59040