[Lldb-commits] [PATCH] D58975: Introduce MinidumpEnums.def textual header

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 6 11:44:07 PST 2019


amccarth accepted this revision.
amccarth added inline comments.


================
Comment at: include/lldb/Formats/MinidumpEnums.def:91
+
+LLDB_HANDLE_PLATFORM(0x0000, Win32S) // Windows 3.1
+LLDB_HANDLE_PLATFORM(0x0001, Win32Windows) // Windows 95-98-Me
----------------
I know you're just moving code, but the comment here is a tiny bit misleading.  Win32S was an extension to Windows 3.1 that let you use much of the then-new 32-bit API even though the underlying system was still 16-bit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58975/new/

https://reviews.llvm.org/D58975





More information about the lldb-commits mailing list