[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 6 10:54:13 PST 2019


JDevlieghere added a comment.

In D58962#1419628 <https://reviews.llvm.org/D58962#1419628>, @jankratochvil wrote:

> In D58962#1419613 <https://reviews.llvm.org/D58962#1419613>, @labath wrote:
>
> > I'd consider moving the test to `lit/lldb-server` (new folder)
>
>
> Don't you mean `lit/LldbServer`? As directories there are UpperCamelCased.


There's a tools folder (`lit/tools`) where this would fit. It's lowercase, possibly to match llvm's `test/tools` directory?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58962/new/

https://reviews.llvm.org/D58962





More information about the lldb-commits mailing list