[Lldb-commits] [lldb] r355519 - [Reproducers] Guard register macros that take lldb::thread_t on Windows

[Jonas Devlieghere via lldb-commits]

Author: jdevlieghere
Date: Wed Mar  6 08:42:33 2019
New Revision: 355519

URL: http://llvm.org/viewvc/llvm-project?rev=355519&view=rev
Log:
[Reproducers] Guard register macros that take lldb::thread_t on Windows

On Windows, lldb::thread_t is just a void*, so the we will try to
allocate an object of type void when deserializing. Undef this for now
until we support void* arguments.

Modified:
    lldb/trunk/source/API/SBReproducer.cpp

Modified: lldb/trunk/source/API/SBReproducer.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBReproducer.cpp?rev=355519&r1=355518&r2=355519&view=diff
==============================================================================
--- lldb/trunk/source/API/SBReproducer.cpp (original)
+++ lldb/trunk/source/API/SBReproducer.cpp Wed Mar  6 08:42:33 2019
@@ -1114,6 +1114,9 @@ SBRegistry::SBRegistry() {
     LLDB_REGISTER_STATIC_METHOD(lldb::SBFileSpec, SBHostOS,
                                 GetUserHomeDirectory, ());
     LLDB_REGISTER_STATIC_METHOD(void, SBHostOS, ThreadCreated, (const char *));
+#ifndef _WIN32
+    // FIXME: On Windows, lldb::thread_t is just a void*, so the we will try to
+    //        allocate an object of type void when deserializing.
     LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadCancel,
                                 (lldb::thread_t, lldb::SBError *));
     LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadDetach,
@@ -1121,6 +1124,7 @@ SBRegistry::SBRegistry() {
     LLDB_REGISTER_STATIC_METHOD(
         bool, SBHostOS, ThreadJoin,
         (lldb::thread_t, lldb::thread_result_t *, lldb::SBError *));
+#endif
   }
   {
     LLDB_REGISTER_CONSTRUCTOR(SBInstruction, ());