[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added a comment.

Run into a few compilation errors building on Windows with msvc.



================
Comment at: source/API/SBReproducer.cpp:40
+  // write into the replay buffer.
+  char buffer[arch_name_len];
+  return SBDebugger::GetDefaultArchitecture(buffer, arch_name_len);
----------------
Array size must be compile-time constant.


================
Comment at: source/API/SBReproducer.cpp:1120
+    LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadCancel,
+                                (lldb::thread_t, lldb::SBError *));
+    LLDB_REGISTER_STATIC_METHOD(bool, SBHostOS, ThreadDetach,
----------------
`lldb::thread_t` is just a `void*` on Windows, so

`return new UnderlyingT(Deserialize<UnderlyingT>());`

tries to allocate `void` object.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57475/new/

https://reviews.llvm.org/D57475