[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 5 12:28:57 PST 2019


How about SerializationFormats?
On Tue, Mar 5, 2019 at 12:22 PM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath added a comment.
>
> FileFormats wouldn't be generic enough to capture the gdb-remote or
> debug-info-server protocol code. However, even calling gdb-remote protocol
> a "format" is still a bit of a stretch. I think there is enough similarity
> between gdb-remote and minidump code for them to be in the same module
> (both convert some (and often the same) data structures into some (file or
> wire) format), but they're also sufficiently different for them to live in
> different places. So yeah, if we want the protocol code to live in a
> different library (Protocols ?), then FileFormats is a better name here.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D58972/new/
>
> https://reviews.llvm.org/D58972
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190305/2afd2239/attachment.html>


More information about the lldb-commits mailing list