[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

Looks mostly good!



================
Comment at: source/Plugins/ExpressionParser/Clang/ClangHost.cpp:45
 
+static bool DefaultComputeClangDirectory(FileSpec &lldb_shlib_spec,
+                                         FileSpec &file_spec, bool verify) {
----------------
While you are at it, could you rename this `DefaultComputeClangResourceDirectory`?
And add a doxygen comment that says it will compute the calng resource directory assuming that clang was installed to the same prefix as lldb?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58748/new/

https://reviews.llvm.org/D58748