[Lldb-commits] [PATCH] D58971: Move MemoryRegionInfo into the Utility module

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 5 08:20:19 PST 2019


labath created this revision.
labath added reviewers: zturner, jingham, JDevlieghere, clayborg.
Herald added a subscriber: mgorny.
labath added a parent revision: D58970: Move RangeMap.h into Utility.

MemoryRegionInfo describes the region of memory in a process, but this
does not have to be the liblldb's notion of a process (in fact, this
class is already used in lldb-server, which has a different hierarchy of
process-related classes).

So a better place for it would be in the Utility module (next to
RegisterValue, State and similar). We might also consider creating a new
module for classes like this, because we currently have a number of
classes which can be described as "properties of a process" in the
Utility module.


https://reviews.llvm.org/D58971

Files:
  include/lldb/Target/MemoryRegionInfo.h
  include/lldb/Utility/MemoryRegionInfo.h
  source/API/SBMemoryRegionInfo.cpp
  source/API/SBMemoryRegionInfoList.cpp
  source/API/SBProcess.cpp
  source/Commands/CommandObjectMemory.cpp
  source/Core/DynamicLoader.cpp
  source/Expression/IRMemoryMap.cpp
  source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  source/Plugins/Process/Darwin/NativeProcessDarwin.h
  source/Plugins/Process/Linux/NativeProcessLinux.h
  source/Plugins/Process/NetBSD/NativeProcessNetBSD.h
  source/Plugins/Process/Utility/LinuxProcMaps.cpp
  source/Plugins/Process/Windows/Common/ProcessWindows.cpp
  source/Plugins/Process/elf-core/ProcessElfCore.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Plugins/Process/mach-core/ProcessMachCore.cpp
  source/Plugins/Process/minidump/MinidumpParser.h
  source/Plugins/Process/minidump/ProcessMinidump.cpp
  source/Target/Process.cpp
  unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
  unittests/Process/minidump/MinidumpParserTest.cpp
  unittests/Target/CMakeLists.txt
  unittests/Target/MemoryRegionInfoTest.cpp
  unittests/Utility/CMakeLists.txt
  unittests/Utility/MemoryRegionInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58971.189329.patch
Type: text/x-patch
Size: 18387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190305/ec208e69/attachment-0001.bin>


More information about the lldb-commits mailing list