[Lldb-commits] [lldb] r355285 - [lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally()

[Michal Gorny via lldb-commits]

Author: mgorny
Date: Sun Mar  3 04:42:43 2019
New Revision: 355285

URL: http://llvm.org/viewvc/llvm-project?rev=355285&view=rev
Log:
[lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally()

Use '127.0.0.1' instead of 'localhost' in ConnectLocally() function
as this is the specific address the server is bound to.  Using
'localhost' may involve trying IPv6 first which may accidentally be used
by another service.

While technically it might be interesting to support IPv6 here, it would
need to be supported properly, with the connection copying family
and address from the listening socket, and possibly without relying
on existence of 'localhost' at all.

Differential Revision: https://reviews.llvm.org/D58883

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp?rev=355285&r1=355284&r2=355285&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Sun Mar  3 04:42:43 2019
@@ -1283,7 +1283,7 @@ GDBRemoteCommunication::ConnectLocally(G
 
   llvm::SmallString<32> remote_addr;
   llvm::raw_svector_ostream(remote_addr)
-      << "connect://localhost:" << listen_socket.GetLocalPortNumber();
+      << "connect://127.0.0.1:" << listen_socket.GetLocalPortNumber();
 
   std::unique_ptr<ConnectionFileDescriptor> conn_up(
       new ConnectionFileDescriptor());