[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Feb 28 16:58:31 PST 2019
JDevlieghere updated this revision to Diff 188813.
JDevlieghere added a comment.
Thanks Pavel. I've updated the patch with your suggestion. I agree it's a lot better :-)
I implemented the logic in the Debugger rather than the SBDebugger because I think the latter should be a thin wrapper, but let me know if you had a particular reason for this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58564/new/
https://reviews.llvm.org/D58564
Files:
lldb/include/lldb/Core/Debugger.h
lldb/include/lldb/Core/IOHandler.h
lldb/include/lldb/Utility/Reproducer.h
lldb/source/Commands/CommandObjectCommands.cpp
lldb/source/Commands/CommandObjectExpression.cpp
lldb/source/Core/Debugger.cpp
lldb/source/Core/IOHandler.cpp
lldb/source/Expression/REPL.cpp
lldb/source/Interpreter/CommandInterpreter.cpp
lldb/source/Utility/Reproducer.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58564.188813.patch
Type: text/x-patch
Size: 17139 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190301/e02a6608/attachment.bin>
More information about the lldb-commits
mailing list