[Lldb-commits] [PATCH] D58748: [ExpressionParser] Test GetClangResourceDir
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 27 23:02:56 PST 2019
teemperor added inline comments.
Comment at: packages/Python/lldbsuite/test/functionalities/paths/TestPaths.py:20
+ # GetClangResourceDir doesn't work on windows yet
Doesn't that mean that we no longer test any of the paths on windows? E.g. if someone breaks `lldb.ePathTypeLLDBShlibDir` we will not see this test failing on Windows. I would prefer of extracting the ClangDir test into it's own method that we mark as failing.
CHANGES SINCE LAST ACTION
More information about the lldb-commits