[Lldb-commits] [PATCH] D58730: Rename Symbols.cpp from Host to Symbols/LocateSymbolFile.{h, cpp}

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 27 12:01:09 PST 2019

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

This seems reasonable to me.  Any Host implementation can live off source/Host/common/Symbols.cpp, and only needs to do anything if it wants to augment that behavior.  Seen that way, it is not defining API's that are a required step in porting to a new platform.  So the API definitions don't need to be specially called out as being required of a Host implementation.  And the implementation is still in source/Host so it's clear that this does provide host specific functionality.  So that seems fine to me.



More information about the lldb-commits mailing list