[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 27 10:54:56 PST 2019

zturner added a comment.

In D58654#1411084 <https://reviews.llvm.org/D58654#1411084>, @labath wrote:

> BTW, what's the reason that you have to have this split now? I understand its attractiveness from a Zen perspective, but it seems to me that at the end of the day, it doesn't have that much impact on the new code you're about to write. It seems to me you could still enforce a clean layering on the new code by just saying "only ever include stuff from Host or Utility". The fact that Host transitively pulls in the kitchen sink is unfortunate, but I don't think it should impact you much. And when we finally clean up Host (which is something that we'll do eventually, and I hope not too far from now), then the new code will magically stop depending on the whole world without any extra effort.

I suppose that actually is fine.



More information about the lldb-commits mailing list