[Lldb-commits] [PATCH] D58699: Adapt the ObjC checker instrumentation to handle objc_msgSend with struct returns

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I chose not to do it that way because I don't think it will ever be the case the msgSend_stret will NOT be a struct return convention so the test isn't relevant (and is a bit confusing) there.  And we may at some point need to do some other work that depends on the flavor of msgSend, so I wanted to keep the distinction.

If all we are ever going to care about is the return convention, then we should remove the msgSend_types classification and just encode the return type and have the Inspect pass over the Super sends.  But that would obscure the fact that this code is all about instrumenting some of the objc_msgSend flavors, and make it harder to read IMO.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58699/new/

https://reviews.llvm.org/D58699