[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 26 13:04:19 PST 2019

labath marked 2 inline comments as done.
labath added inline comments.

Comment at: include/lldb/Host/UserIDResolver.h:9
zturner wrote:
> I wonder if this class should actually be in Host.  While some specific implementation of it might be host-dependent, the interface itself is not.  I kind of envision at some point in the future having a target that contains all of our core interfaces that someone can include and re-implement small pieces of the debugger without having to bring in the entire thing.  This is also nice from a mocking / unittesting perspective.
> So I think this would be better if it were in Utility (or some other top-level library such as Interfaces)
Yes, I've wondered about that too. I went with Host because that was enough to make things work, but I certainly see the case for this being Utility too. I'll move it there.



More information about the lldb-commits mailing list