[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L for just-built libc++

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Unfortunately I don't know of a substantially better way to solve. I have one small improvement inline. Also, I take it this means running tests without a libc++ checkout is not supported on NetBSD. Maybe you should add netbsd to the cmake code where we print the darwin warning if you build without libc++ checked out.



================
Comment at: lldb/lit/Suite/lit.cfg:35-36
 
+# Library path may be needed to locate just-built clang.
+config.environment['LLVM_LIBS_DIR'] = config.llvm_libs_dir
+
----------------
Instead of passing this via the environment, you should arrange so that `--env LLVM_LIBS_DIR=dir` gets passed to dotest.py. This will stop people from pounding the head against the wall on why do the tests behave differently when run from lit vs. directly from command line.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58630/new/

https://reviews.llvm.org/D58630